chore: All samples working with Scala 3, CI test coverage #32421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
force-pushed
the
wip-make-sure-samples-work-with-scala3
branch
from
e1e3849
to
5ce58d4
Compare
|
Green sample check run in https://github.com/akka/akka/actions/runs/9154749983 |
efgpinto
approved these changes
May 20, 2024
Co-authored-by: Eduardo Pinto <efgpinto@gmail.com>
|
Let's start like this. And follow up with bumps, I think it especially makes sense to switch the quickstart for consistency with the g8 template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should go further and even have them default on 3 and only test on 2.13?