Add:KafkaProducer validate message against schema before emitting . #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue#7742
github-actions
bot
added
lib:util-nestjs-kafka
app:notification-service
app:git-sync-manager
app:amplication-git-push-webhook-service
app:amplication-git-pull-request-service
app:amplication-git-pull-service
app:amplication-storage-gateway
app:amplication-build-manager
app:amplication-server
labels
overbit
requested changes
Feb 15, 2024
Comment on lines
+27
to
+33
| if (!schemaIds) { | ||
| throw new Error('Missing schema IDs'); | ||
| } | ||
| const validationResult = await this.kafkaClient.validate(topic, message, schemaIds); | ||
| if (validationResult.errors) { | ||
| throw new Error('Message does not conform to the specified schema'); | ||
| } |
There was a problem hiding this comment.
@xonx4l sorry but I'm struggling to understand how the validation will work.
In addition validate doesn't exists in the kafkaClient object...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #7742
PR Details
This method first validates the message against the provided schema IDs. If the message does not conform to the specified schema, it throws an error. Then, it proceeds to serialize the message using the provided schema IDs and emits the message to the Kafka client. This way, the KafkaProducerService ensures that only valid messages are published to the Kafka topic, preventing potential issues for the consumers.
PR Checklist
npm testdoesn't throw any error