fix: fix the ellipsis bug for pre element #48968

nova1751 · 2024-05-18T07:27:56Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

The css property white-space: normal will cause the \n to not work in pre tag when the text is used as MeasureText. Removing it may be a good solution.🤔

📝 Changelog

Language	Changelog
🇺🇸 English	Fix the bug where the ellipsis option of `Typography` component doesn't work normally in `pre` tag
🇨🇳 Chinese	修复 `Typography` 组件的 `ellipsis`选项在 `pre` 标签中没有正常工作的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

stackblitz · 2024-05-18T07:27:59Z

Run & review this pull request in StackBlitz Codeflow.

github-actions · 2024-05-18T07:28:08Z

👁 Visual Regression Report for PR #48968 Failed ❌

🎯 Target branch: master (9d13485)
📖 View Full Report ↗︎

Expected (Branch master)	Actual (Current PR)	Diff
typography-ellipsis-debug.compact.png	typography-ellipsis-debug.compact.png
typography-ellipsis-debug.compact.png	typography-ellipsis-debug.compact.css-var.png
typography-ellipsis-debug.dark.png	typography-ellipsis-debug.dark.png
typography-ellipsis-debug.dark.png	typography-ellipsis-debug.dark.css-var.png
typography-ellipsis-debug.default.png	typography-ellipsis-debug.default.png
typography-ellipsis-debug.default.png	typography-ellipsis-debug.default.css-var.png
typography-ellipsis-middle.compact.png	typography-ellipsis-middle.compact.png
typography-ellipsis-middle.compact.png	typography-ellipsis-middle.compact.css-var.png
typography-ellipsis-middle.dark.png	typography-ellipsis-middle.dark.png
typography-ellipsis-middle.dark.png	typography-ellipsis-middle.dark.css-var.png

Check Full Report for details

If you think the visual diff is acceptable, please check:

Visual diff is acceptable

github-actions · 2024-05-18T07:28:09Z

codesandbox-ci · 2024-05-18T07:35:08Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov · 2024-05-18T07:48:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2e011a3) to head (2d0f507).
Report is 15 commits behind head on master.

❗ Current head 2d0f507 differs from pull request most recent head b1ee035

Please upload reports for the commit b1ee035 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##            master    #48968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12976     12976           
  Branches      3400      3400           
=========================================
  Hits         12976     12976

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nova1751 · 2024-05-18T17:02:45Z

After fixed:

Typography.-.Ant.Design.2.-.-.Microsoft.Edge.2024-05-19.01-01-32.mp4

nova1751 · 2024-05-24T02:20:51Z

Any progress in this PR? @zombieJ @afc163

zombieJ · 2024-05-31T02:44:03Z

This broken the debug demo:

* fix: fix Checkbox.Group type * fix: fix Checkbox.Group type * fix: fix Checkbox.Group type * fix: remove type * fix: any

* docs: 5.17.4 changelog * docs: more

Co-authored-by: liangchaofei <liangchaofei@liangchaofeideMacBook-Pro.local>

* docs: add getValueProps demo * feat: normalize * feat: normalize * feat: name * feat: name * feat: doc * feat: date * feat: tz * feat: tz

* docs(FAQ): Remove expired links * chore: adjusting update * chore: adjusting update

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>

Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>

* fix: Tour onClose wrong current argument * test: add test case * Update components/tour/panelRender.tsx Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

* chore: rollback ci * test: one day

Co-authored-by: 吴必炫 <wubixuan@rlink.com>

…t-design#49136) Co-authored-by: dengxia <dengxia@tanqingsk.com>

…0.0 (ant-design#49142) Bumps [@types/react-highlight-words](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-highlight-words) from 0.16.7 to 0.20.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-highlight-words) --- updated-dependencies: - dependency-name: "@types/react-highlight-words" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update index.zh-CN.md Signed-off-by: LemonTency <120943952@qq.com> * Update index.zh-CN.md Signed-off-by: LemonTency <120943952@qq.com> --------- Signed-off-by: LemonTency <120943952@qq.com>

github-actions · 2024-05-31T05:27:56Z

Hi @nova1751. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

nova1751 · 2024-05-31T05:35:43Z

Oops, I rebase the master branch, which cause the PR to be closed forcely. ☹️

zombieJ · 2024-06-03T07:46:21Z

Seems the branch has been removed? I can not reopen the PR.

nova1751 · 2024-06-03T07:53:39Z

Seems the branch has been removed? I can not reopen the PR.

Sorry for the misoperation, I opened a new one. See #49168.

nova1751 added 3 commits May 18, 2024 15:12

fix: fix the ellipsis bug for pre element

1da18fb

Merge remote-tracking branch 'origin/master' into fix/typography

5a091db

fix: remove the white-space property

32050ba

Merge branch 'master' into fix/typography

2d0f507

zombieJ self-requested a review May 27, 2024 09:17

zombieJ self-assigned this May 31, 2024

zombieJ and others added 16 commits May 31, 2024 11:20

test: update snapshot

b680fdd

chore: clean up

3250888

test: update snapshot

f00dce2

fix: fix Checkbox.Group type (ant-design#49073)

3b9d04e

* fix: fix Checkbox.Group type * fix: fix Checkbox.Group type * fix: fix Checkbox.Group type * fix: remove type * fix: any

docs: 5.17.4 changelog (ant-design#49076)

b0e5e02

* docs: 5.17.4 changelog * docs: more

site: update site scrollbar style (ant-design#49088)

6951c97

docs: update antd pro i18n link (ant-design#49098)

a22a534

Co-authored-by: liangchaofei <liangchaofei@liangchaofeideMacBook-Pro.local>

docs: add getValueProps demo (ant-design#49072)

3849b9b

* docs: add getValueProps demo * feat: normalize * feat: normalize * feat: name * feat: name * feat: doc * feat: date * feat: tz * feat: tz

docs(FAQ): Remove expired links (ant-design#49082)

d433012

* docs(FAQ): Remove expired links * chore: adjusting update * chore: adjusting update

docs: Updated typo of selected (ant-design#49104)

76b6198

Signed-off-by: JeevaRamanathan <64531160+JeevaRamanathan@users.noreply.github.com>

chore: upgrade deps (ant-design#49103)

1e1a4a9

Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>

fix: Tour onClose wrong current argument (ant-design#49124)

036e32c

* fix: Tour onClose wrong current argument * test: add test case * Update components/tour/panelRender.tsx Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: afc163 <afc163@gmail.com>

test: Update test of demo (ant-design#49140)

a936a1c

* chore: rollback ci * test: one day

docs: Modify inappropriate words (ant-design#49143)

ac2d1ee

Co-authored-by: 吴必炫 <wubixuan@rlink.com>

fix: Anchor - The replace attribute causes no scrolling animation (an…

926ef9a

…t-design#49136) Co-authored-by: dengxia <dengxia@tanqingsk.com>

coding-ice and others added 2 commits May 31, 2024 13:18

type: remove unnecessary types (ant-design#49146)

638fc0f

docs: Update AutoComplete index.zh-CN.md (ant-design#49139)

b1ee035

* Update index.zh-CN.md Signed-off-by: LemonTency <120943952@qq.com> * Update index.zh-CN.md Signed-off-by: LemonTency <120943952@qq.com> --------- Signed-off-by: LemonTency <120943952@qq.com>

github-actions bot assigned afc163, MadCcc and xrkffgg May 31, 2024

github-actions bot closed this May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix the ellipsis bug for pre element #48968

fix: fix the ellipsis bug for pre element #48968

nova1751 commented May 18, 2024 •

edited by yoyo837

stackblitz bot commented May 18, 2024

github-actions bot commented May 18, 2024 •

edited

github-actions bot commented May 18, 2024 •

edited

codesandbox-ci bot commented May 18, 2024 •

edited

codecov bot commented May 18, 2024 •

edited

nova1751 commented May 18, 2024

nova1751 commented May 24, 2024

zombieJ commented May 31, 2024

github-actions bot commented May 31, 2024

nova1751 commented May 31, 2024

zombieJ commented Jun 3, 2024

nova1751 commented Jun 3, 2024

fix: fix the ellipsis bug for pre element #48968

fix: fix the ellipsis bug for pre element #48968

Conversation

nova1751 commented May 18, 2024 • edited by yoyo837

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self-Check before Merge

stackblitz bot commented May 18, 2024

github-actions bot commented May 18, 2024 • edited

👁 Visual Regression Report for PR #48968 Failed ❌

github-actions bot commented May 18, 2024 • edited

codesandbox-ci bot commented May 18, 2024 • edited

codecov bot commented May 18, 2024 • edited

Codecov Report

nova1751 commented May 18, 2024

nova1751 commented May 24, 2024

zombieJ commented May 31, 2024

github-actions bot commented May 31, 2024

nova1751 commented May 31, 2024

zombieJ commented Jun 3, 2024

nova1751 commented Jun 3, 2024

nova1751 commented May 18, 2024 •

edited by yoyo837

github-actions bot commented May 18, 2024 •

edited

github-actions bot commented May 18, 2024 •

edited

codesandbox-ci bot commented May 18, 2024 •

edited

codecov bot commented May 18, 2024 •

edited