Add joinRoom, leftRoom, roomCreated, roomEnded Web Hooks #6275
Conversation
There was a problem hiding this comment.
Hi @lastpeony,
Thank you for the implementations.
There are two things that blocks me to merge this PR
- Concept of room naming
- Backward compatibility
I've added comments for that.
Thank you
Oguz
| @@ -911,6 +923,47 @@ public void muxingFinished(final String streamId, File file, long startTime, lon | |||
|
|
|||
| } | |||
|
|
|||
| public void notifyRoomHook(String action, String roomId, String myTrackId, boolean playOnly) { | |||
There was a problem hiding this comment.
Please remove the room concept. It's about mainTrack and subTracts. It can be used for multiview streaming or it can be used in conferencing or something else.
I mean change the naming concept from room to tracks
| String vodName, String vodId, String metadata) { | ||
| logger.info("Running notify hook url:{} stream id: {} mainTrackId:{} action:{} vod name:{} vod id:{}", url, id, mainTrackId, action, vodName, vodId); | ||
| if (url != null && !url.isEmpty()) { | ||
| JSONObject hookPayload = new JSONObject(); |
There was a problem hiding this comment.
Sending JSON is a good idea. On the other hand, it breaks the backward compatibility.
What can you do about migrating to JSON gently by keeping backward compatibility?
|
#6253
https://gitlab.com/Ant-Media/Ant-Media-Enterprise/-/merge_requests/679