Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to combine languages #3530

Open
zbyju opened this issue Dec 5, 2023 · 6 comments
Open

Add option to combine languages #3530

zbyju opened this issue Dec 5, 2023 · 6 comments
Labels
enhancement New feature or request.

Comments

@zbyju
Copy link

zbyju commented Dec 5, 2023

Is your feature request related to a problem? Please describe.

I think it would be nice if there was a way to combine languages into one (not always but and option to do so). Example: Typescript + Javascript, Python + Jupyter Notebook, or combining the usage of javascript frameworks

Describe the solution you'd like

I would like to have an option to specify what languages I want to combine into one and possibly even specify the name through the parameters.

Describe alternatives you've considered

I've considered just hiding one of them, but then it isn't really representative, on the other hand I don't really want to have 5 different frontend frameworks on my profile or similar languages taking several spots.

Additional context

No response

@zbyju zbyju added the enhancement New feature or request. label Dec 5, 2023
@MAiKo26
Copy link

MAiKo26 commented Dec 13, 2023

yep I was just about to come here to suggest this, a lot of languages like Javascript/Typescript or SCSS/CSS could be cool to combine

@qwerty541
Copy link
Collaborator

I see a couple of problems with implementation of this feature:

  • Languages card currently supports five different layouts, three of them (compact, pie and donut-vertical) are not intended for long names of languages groups. This will break card alignment.
  • How you are going to choose colors for languages groups?

I would also like to say that I don’t see much point in this feature since you are able show more languages (using langs_count query parameter) or hide redundant languages (using hide query paramter).

Let's also wait for other maintainers input about this.

@victormurcia
Copy link

I'm just going to add in here and say that this would be a nice feature to have as well. Especially for things like Jupyter Notebooks and Python for instance.

@rickstaa
Copy link
Collaborator

rickstaa commented Jan 2, 2024

@zbyju, thanks for your feature request. However, I agree with @qwerty541 that this would be tough to implement without adding significant code changes. I, however, will leave your feature request open to check interest from the community 👍🏻.

@zbyju
Copy link
Author

zbyju commented Jan 5, 2024

Just to react to a possible implementation to deal with the issues suggested by @qwerty541:

Let's say we want to combine TypeScript+JavaScript - I came up with 2 options of implementing this:

  1. The user specifies a group of combined languages [typescript, javascript]. In this implementation the 1st element would be treated as the "leader" and everything else would get combined into it. Meaning we would end up with only TypeScript and JavaScript would be added to the percentage of TypeScript.
  2. The user specifies a group [TS/JS, typescript, javascript]. In this implementation again the group would be named after the first element (in this case TS/JS) and then all the languages following it would get aggregated into that group. The group could get ignored if the name of the group is too long. The color of the group could be determined either by the first language element (in this case it would be typescript's color) or it could combine all the colors together (using average mixing, for example).

I understand the concerns and limited interest for this feature, just wanted to add to the discussion if it ever came to it being implemented ❤️

@yaten2302
Copy link

yaten2302 commented May 4, 2024

Hey @rickstaa @qwerty541, if this feature is required, then may I work on it? It's a great feature request by @zbyju. I've also previously contributed to GRS and I'm familiar with the codebase, so if this issue is required, then I would definitely like to work on this👍(if it's required for the community ofc)
My previous contributions:
#3467
#3338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

6 participants