Added card_width argument to gist card #3467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaten2302 is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
documentation
rickstaa
reviewed
Nov 11, 2023
rickstaa
reviewed
Nov 11, 2023
tests/renderGistCard.test.js
Outdated
| expect(document.querySelector("svg")).toHaveAttribute("width", "400"); | ||
| }); | ||
|
|
||
| it("should render with custom width set and limit minimum width", () => { |
There was a problem hiding this comment.
You are performing the same test multiple times. Please consider replacing it with:
it("should render with custom width set", () => {
document.body.innerHTML = renderGistCard(data);
expect(document.querySelector("svg")).toHaveAttribute("width", "400");
document.body.innerHTML = renderGistCard(data, { card_width: 400 });
expect(document.querySelector("svg")).toHaveAttribute("width", "400");
});
it("should limit minimum width when the custom width is too small", () => {
document.body.innerHTML = renderGistCard(data, { card_width: 1 });
expect(document.querySelector("svg")).toHaveAttribute("width", "280");
});
rickstaa
reviewed
Nov 11, 2023
There was a problem hiding this comment.
@yaten2302, thanks for applying the changes I requested. I made some small last suggestions that should be used, and then the PR is ready for merge 🚀.
Co-authored-by: Rick Staa <rick.staa@outlook.com>
|
@rickstaa, made the changes, could you please review 👍 |
This was referenced May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rickstaa, I've created a new PR for adding the
card_widthargument to the gist card, since there were some issues in the previous one.Could you also please check that if the changes made in the test file are correct?