Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding tls and tls verify support for Kafka-logger #10104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macdoor
Copy link

@macdoor macdoor commented Aug 29, 2023

Description

Adding tls and tls verify support for Kafka-logger, then it will support Kafka's SASL_SSL authentication mode

  • attribute tls , type object
  • attribute tls.verify, type boolean, default false

Fixes # (issue)
#9353

Checklist

  • [v] I have explained the need for this PR and the problem it solves
  • [v] I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@macdoor macdoor changed the title Add tls and tls verify support feat: adding tls and tls verify support for Kafka-logger Aug 29, 2023
@Revolyssup
Copy link
Contributor

@macdoor Will you also add the appropriate test cases?

@macdoor
Copy link
Author

macdoor commented Aug 29, 2023

@macdoor Will you also add the appropriate test cases?

@Revolyssup ok

properties = {
verify = {
type = "boolean",
default = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need one more space

@monkeyDluffy6017 monkeyDluffy6017 added wait for update wait for the author's response in this issue/PR need test cases labels Sep 4, 2023
@Sn0rt
Copy link
Contributor

Sn0rt commented Sep 15, 2023

@macdoor the document of this plugin and the test case both needed.

@macdoor
Copy link
Author

macdoor commented Sep 15, 2023 via email

@monkeyDluffy6017
Copy link
Contributor

@macdoor We are still waiting for you, thanks!

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@shreemaan-abhishek
Copy link
Contributor

@macdoor are you going to work on this?

@Revolyssup
Copy link
Contributor

ping @macdoor

Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test cases stale wait for update wait for the author's response in this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants