Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Optimize ServerLoadProtection. #15813

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Zzih96
Copy link
Contributor

@Zzih96 Zzih96 commented Apr 8, 2024

Purpose of the pull request

  • Fix the issue where configurations couldn't load properly due to case sensitivity
  • add configuration validation
  • and modify error log messages.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

… sensitivity, add configuration validation, and modify error log messages.
@ruanwenjun
Copy link
Member

Are you sure there will exist case sensitivity problem? add configuration LGTM, some change should already exist in #15803

@ruanwenjun
Copy link
Member

Please resolve the conflicts.

@Zzih96
Copy link
Contributor Author

Zzih96 commented Apr 9, 2024

LGTM

In the Kubernetes environment, I couldn't inject MASTER_SERVER_LOAD_PROTECTION_MAX_JVM_MEMORY_USAGE_PERCENTAGE_THRESHOLDS intomaxJVMMemoryUsagePercentageThresholds as configured. However, modifying it tomaxJvmMemoryUsagePercentageThresholds does allow successful injection. I suspect this might be related to the getters and setters generated by Lombok.

@Zzih96
Copy link
Contributor Author

Zzih96 commented Apr 9, 2024

Please resolve the conflicts.

I'll give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants