Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8129] Support topic reserved time in tiered storage #8130

Merged
merged 3 commits into from
May 22, 2024

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented May 13, 2024

Which Issue(s) This PR Fixes

Fixes #8129

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 42.99%. Comparing base (159a603) to head (230fe54).
Report is 8 commits behind head on develop.

Files Patch % Lines
...ache/rocketmq/broker/topic/TopicConfigManager.java 10.00% 16 Missing and 2 partials ⚠️
...che/rocketmq/tieredstore/file/FlatMessageFile.java 0.00% 3 Missing ⚠️
...pache/rocketmq/tieredstore/file/FlatFileStore.java 0.00% 2 Missing ⚠️
...tieredstore/metrics/TieredStoreMetricsManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8130      +/-   ##
=============================================
+ Coverage      42.94%   42.99%   +0.05%     
- Complexity     10387    10439      +52     
=============================================
  Files           1270     1270              
  Lines          88694    89056     +362     
  Branches       11401    11510     +109     
=============================================
+ Hits           38092    38292     +200     
- Misses         45914    46040     +126     
- Partials        4688     4724      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins
Copy link
Member

There is a suggestion in #8129

@yuz10
Copy link
Member Author

yuz10 commented May 15, 2024

There is a suggestion in #8129

thanks for your suggestion, I will modify soon

@lizhimins lizhimins changed the title [ISSUE #8129] support update topic reserved time for topic in tiered storage [ISSUE #8129] Support topic reserved time in tiered storage May 20, 2024
Copy link
Member

@lizhimins lizhimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiered storage feature is optional, should not throw exception here

@lizhimins lizhimins merged commit 1b42515 into apache:develop May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] support update topic reserved time for topic in tiered storage
3 participants