Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8159] Fix proxy discarding response when channel is unwritable #8160

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ISSUE #8159] Fix proxy discarding response when channel is unwritable #8160

wants to merge 1 commit into from

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented May 17, 2024

Which Issue(s) This PR Fixes

Fixes #8159

Brief Description

  1. do not check channel.isWritable when writeResponse
  2. Reuse NettyRemotingAbstract.writeResponse to get better exception handling

How Did You Test This Change?

@drpmma drpmma self-requested a review May 20, 2024 02:42
drpmma
drpmma requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss it further in #8159 and put this PR on hold for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpmma drpmma drpmma requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Response should not be discarded even the channel is unwritable
2 participants
@redlsz @drpmma