Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out base settings in stdlib for reuse #493

Closed
wants to merge 1 commit into from

Conversation

holzensp
Copy link
Contributor

This PR defines pkl:AbstractSettings as a common parent module for pkl:settings and pkl:Project.

Since user-level evaluator settings should be limited to user/machine specific ones (to avoid unnecessary "works on my machine"), whereas PklProjects might want to set more detailed settings.

There isn't an overwhelming win from making pkl:AbstractSettings a super-module, other than evaluatorSettings (and possibly other properties in the future) being defined in all children by default. Alternatively, pkl:AbstractSettings could define all classes that might be used somewhere, and it just being imported, i.e.

settings.pkl:

module pkl.settings

import "pkl:AbstractSettings"

proxy: AbstractSettings.Proxy

//...

Project.pkl:

module pkl.Project

import "pkl:AbstractSettings"

evaluatorSettings: AbstractSettings.Evaluator

//...

@holzensp
Copy link
Contributor Author

Rolling this into Proxy PR

@holzensp holzensp closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant