feat: Make Postgres DB URL configurable via envs #33543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mohanarpit
reviewed
May 20, 2024
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| ACTIVE_PROFILE=test | |||
|
|
|||
| APPSMITH_MONGODB_URI="mongodb://localhost:27017/appsmith" | |||
There was a problem hiding this comment.
Minor: Do we want to keep the APPSMITH_MONGODB_URI in the example env file? This way, it's explicit that this variable still exists for users who may want to run Appsmith with MongoDB.
There was a problem hiding this comment.
@mohanarpit Yeah makes sense right now. Once we start to roll out Appsmith with Postgres we can move away from this env to avoid future confusion.
mohanarpit
approved these changes
May 20, 2024
|
Closing, as changes will be addressed once we merge #33429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.