Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Removing commented code to create dummy commit for testing ci limited tests #33546

Closed
wants to merge 9 commits into from

Conversation

mohanarpit
Copy link
Member

@mohanarpit mohanarpit commented May 17, 2024

This is a draft PR for testing if cypress/grep can work and we can get rid of ci-test-limited workflow.

Automation

/ok-to-test tests="List widget V2 functionality with button, button group and icon button widgets"

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9129751454
Commit: 764c4a5
Cypress dashboard url: Click here!
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

This update focuses on cleaning up and simplifying the Cypress test support files. It removes unused or commented-out code to improve readability and maintainability. Key changes include the removal of the goToEditFromPublish command and various commented-out lines related to file handling, field value evaluation, and waiting logic. Additionally, it removes unnecessary logging and cookie preservation code, streamlining the test setup and execution process.

Changes

File Path Change Summary
app/client/cypress/support/commands.js - Removed the goToEditFromPublish command.
- Commented out code for downloading/validating files.
- Commented out code for field value evaluation and waiting logic.
app/client/cypress/support/e2e.js - Removed //cy.log(error.message); from exception handling.
- Removed //console.warn = () => {}; from before hooks.
- Removed //Cypress.Cookies.preserveOnce("SESSION", "remember_token"); from login handling.
- Removed //cy.window().then((win) => (win.onbeforeunload = undefined)); from beforeEach hooks.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mohanarpit mohanarpit marked this pull request as draft May 17, 2024 07:55
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels May 17, 2024
@mohanarpit mohanarpit added the ok-to-test Required label for CI label May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
@mohanarpit mohanarpit added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 17, 2024
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label May 24, 2024
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant