Add promtool and net-tools to test container #20440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jsteemann
changed the title
mpoeter
force-pushed
the
chore/add-promtool-to-test-container
branch
from
08f7e8f
to
ffdd3c1
Compare
mpoeter
changed the title
dothebart
approved these changes
May 28, 2024
mpoeter
force-pushed
the
chore/add-promtool-to-test-container
branch
from
8aebf39
to
514f0dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
The promtool is used in one of our js tests to validate our metrics against the prometheus format. If this tool is missing, the test is simply not executed.
This PR add does not install a complete prometheus, but only adds the promtool, and only for the amd64 image. I suppose it is enough if this test runs for x64 only (the metrics should be the same for all architectures).
It also installs net-tools since the testing framework tries to start netstat to gather some information about resource usage.