Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup/sut checker modules #20880

Merged
merged 40 commits into from
May 28, 2024
Merged

Cleanup/sut checker modules #20880

merged 40 commits into from
May 28, 2024

Conversation

dothebart
Copy link
Contributor

Scope & Purpose

make SUT health checkers modular.

  • 🔨 Refactoring/simplification

@dothebart
move various testrunners into their own file.
952ff29
@dothebart
leftovers
cd35dcc
@dothebart
leftovers
ea33edc
@dothebart
Rework code distribution of test management
62d0a95 
- add a way to scan test infrastructure for commandline options and
  their defaults
- move most options out of `testing.js` into the modules that work with
  these options
- options used by instance.js and instance-manager.js will end in
  instance-manager.js
- introduce API function to add documentation including duplicate
  checking
- remove redundand options from testsuites
- locate and fix duplicates
- move portManager into its own file
@dothebart
forgotten changes
6865c83
@dothebart
lint
caff648
@dothebart
further cleanup
fa350c3
@dothebart
one more place to follow cleanup of the crashutils
968490d
@dothebart
add new portmanager file
5d1055a
@dothebart
ruby leftover
2be3078
@dothebart
re-Add code required under different conditions
9872eff
@dothebart
forward port specifying database to makedata
af69b68
@dothebart
move SUT-checkers into own modules
e6dbd7d
@cla-bot cla-bot bot added the cla-signed label Apr 30, 2024
@dothebart dothebart marked this pull request as ready for review May 7, 2024 09:17
@jsteemann jsteemann added this to the devel milestone May 24, 2024
dothebart and others added 20 commits May 24, 2024 16:14
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/collections.js
57914a5 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/collections.js
a813a20 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/collections.js
7f12839 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/databases.js
f4eeff4 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/failurepoint…
a58dbe3 
…s.js

Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/graphs.js
f963d40 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/tasks.js
211d910 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/tasks.js
b3d9acf 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/tasks.js
0c12926 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/graphs.js
93fdc18 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/users.js
7eb2716 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/users.js
3abb5bf 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/users.js
b32fa1e 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/views.js
80ac3ca 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/sutcheckers/views.js
865bd58 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/testrunner.js
2c1d068 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/testing.js
dc0f781 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart @jsteemann
Update js/client/modules/@arangodb/testutils/test-utils.js
fc3d412 
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
@dothebart
as @jsteemann pointed out, we don't need this for views, only collect…
98de138 
…ions. Do away with cut'n' paste leftovers.
@dothebart
Merge branch 'devel' into cleanup/sut-checker-modules
e7f7d50
jsteemann
jsteemann approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to the best of my knowledge, but I do not consider myself an expert on this area of code.

@KVS85 KVS85 merged commit e4d0716 into devel May 28, 2024
1 of 2 checks passed
@KVS85 KVS85 deleted the cleanup/sut-checker-modules branch May 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteemann jsteemann jsteemann approved these changes

@naushniki naushniki naushniki approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dothebart @jsteemann @naushniki @KVS85