Remove non-local AgencyCallbacks #20946
Merged
+108
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteemann
reviewed
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Deleted the non-local variant of AgencyCallbacks - they are unused and don't make sense any longer. Also got rid of ArangodServer as a dependency of AgencyComm, AgencyCallback, and AgencyCallbackRegistry. The latter as part of a larger undertaking to make features reusable again (note that features needing ArangodServer cannot be used without a complete ArangodServer, which makes them practically unusable for other tools or certain tests).
Related Information