fix(ui): Add title for full content without clicking (issue #17600) #18243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunyeongchoi
force-pushed
the
refactoring/ui-table
branch
2 times, most recently
from
d6e8715
to
662e0a3
Compare
Signed-off-by: sunyeongchoi <suoung0716@gmail.com>
sunyeongchoi
force-pushed
the
refactoring/ui-table
branch
from
662e0a3
to
00512f7
Compare
Signed-off-by: sunyeongchoi <suoung0716@gmail.com>
| <div className='columns small-1 xxxlarge-1'>{[res.group, res.kind].filter(item => !!item).join('/')}</div> | ||
| <div className='columns small-1 xxxlarge-1'>{res.syncWave || '-'}</div> | ||
| <div className='columns small-2 xxxlarge-1'>{res.namespace}</div> | ||
| <div className='columns small-1 xxxlarge-1' title={[res.group, res.kind].filter(item => !!item).join('/')}> |
There was a problem hiding this comment.
let's move this filtering to local variable, to reuse code
There was a problem hiding this comment.
Thanks for your review! I applied your review and defined a local variable to reuse.
df59d79
| <div className='columns small-1 xxxlarge-1'>{[res.group, res.kind].filter(item => !!item).join('/')}</div> | ||
| <div className='columns small-1 xxxlarge-1'>{res.syncWave || '-'}</div> | ||
| <div className='columns small-2 xxxlarge-1'>{res.namespace}</div> | ||
| <div className='columns small-1 xxxlarge-1' title={[res.group, res.kind].filter(item => !!item).join('/')}> |
There was a problem hiding this comment.
Would you consider using the tooltip component from argo-ui, which is already available, instead of the native tooltip?
There was a problem hiding this comment.
Thanks for your review! I applied it as a tooltip in argo-ui as you said, and it looked much prettier :)
df59d79
Signed-off-by: sunyeongchoi <suoung0716@gmail.com>
oleksandr-codefresh
approved these changes
May 20, 2024
pasha-codefresh
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17600
If the text is long, it will be cut off and can't see the entire text. So I added
title.When hovering the mouse, the user can see the entire text.
Checklist:
Results
Before
After(Before review)
NAME field title
GROUP/KIND field title
SYNC ORDER field title
NAMESPACE field title
CREATED AT field title
After(After review)
NAME field title
GROUP/KIND field title
SYNC ORDER field title
NAMESPACE field title
CREATED AT field title
