Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amis-editor): 补全编辑器遗漏的 theme 参数 #8099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sun79
Copy link
Contributor

@Sun79 Sun79 commented Sep 13, 2023

What

🤖 Generated by Copilot at 936168b

This pull request adds the theme prop to various amisRender function calls in the amis-editor package, which renders different components for editing amis schemas. This is to make the amis-editor support different themes and pass the theme information to the rendered components.

🤖 Generated by Copilot at 936168b

Oh, we are the coders of the amis-editor
And we work on the theme prop all day
We pass it to the amisRender function
To make the components look the right way

Why

How

🤖 Generated by Copilot at 936168b

  • Add theme prop to amisRender function calls in various components to pass theme information to rendered components (link, link, link, link, link, link, link, link)
  • Add theme prop to render function calls in TimelineItemControl component to pass theme information to rendered components (link, link)
  • Declare theme variable from props in TimelineItemControl component and render function of the same component to prepare for passing theme prop to amisRender function calls (link, link)

@github-actions
Copy link

👍 Thanks for this!
🏷 I have applied any labels matching special text in your issue.

Please review the labels and make any necessary changes.

@github-actions github-actions bot added the fix label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant