Show filter in minimal mode if the table is filtered #2208
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 19b2de1 in 1 minute and 14 seconds
More details
- Looked at
218lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_bgXpSr05j0ifUKyE
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 22 hours left in your free trial, upgrade for $20/seat/month or contact us.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 7853ce2 in 1 minute and 29 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_DljhvXzmEVmrtBLg
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 22 hours left in your free trial, upgrade for $20/seat/month or contact us.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
When minimal mode is active, and there are filters in the table, we should be able to see it and clear it. To close the filter, we can do one of these:
Clear the filter manually and then click away from the input
Click the clear button
Summary:
Enhances filter visibility in minimal mode by adding utility functions and updating Vue components to use these functions for consistent filter handling.
Key points:
createTableFilterandcheckEmptyFiltersinutils.ts.RowFilterBuilder.vueto handle filter visibility in minimal mode.RowFilterBuilderinTableTable.vuebut control visibility internally.Generated with ❤️ by ellipsis.dev