Spelling #178

jsoref · 2023-06-27T14:06:27Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/bigcapital/actions/runs/5390721361#summary-14591784959

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/bigcapital/actions/runs/5390722721#summary-14591789667

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

vercel · 2023-06-27T14:08:22Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bigcapital-webapp	❌ Failed (Inspect)			Jun 27, 2023 2:08pm

jsoref

Fwiw, I've been maintaining this for a while now, it gets conflicts constantly. They're generally fairly easy to resolve, but there isn't much point in me doing another round until a reviewer looks things over describes how they'd want to approach it.

I'm not done annotating this PR, but the GitHub PR viewer is really slow, so I've marked >400 of the files as viewed.

If I were reviewing this, I'd probably just pull in x commits into a PR in a personal fork and review them and then make/ask for changes and merge.

GitHub doesn't like PRs with >250 commits, and it isn't really a fan of PRs with >1000 files.

As PRs go, this is on the small side, I've had PRs with 1000 commits. In general maintainers suggest a split, e.g. by directory or file type. Here I don't think either would help as they're are basically two directories and two file types.

jsoref · 2023-06-27T14:07:56Z

CHANGELOG.md

- fixed: move `packaeg-lock.json` inside docker container.
+- fixed: move `package-lock.json` inside docker container.


some projects don't like changing their changelogs, but I'd argue it's worth it in this case.

jsoref · 2023-06-27T14:09:00Z

CHANGELOG.md

@@ -86,7 +86,7 @@ All notable changes to Bigcapital server-side will be in this file.

 ## [0.8.3] - 06-04-2023

-`@bigcaptial/monorepo`


jsoref · 2023-06-27T14:09:53Z

packages/server/resources/locales/ar.json

-  "An account that holds valuation of products or goods that availiable for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
+  "An account that holds valuation of products or goods that available for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",


Some projects don't like changing translation files. I can easily omit them...

jsoref · 2023-06-27T14:10:49Z

packages/server/resources/locales/en.json

-  "An account that holds valuation of products or goods that availiable for sale.": "An account that holds valuation of products or goods that availiable for sale.",
+  "An account that holds valuation of products or goods that available for sale.": "An account that holds valuation of products or goods that available for sale.",


Some projects don't like changing translation keys. I'm happy to drop such changes (or any other changes...)

jsoref · 2023-06-27T14:12:46Z

packages/server/resources/scss/modules/credit.scss

-      tbody tr.blanace-due td {
+      tbody tr.balance-due td {


If a html class is used beyond the code of a repository, it probably shouldn't be changed, but if the code is self-contained, it makes sense to change it...

jsoref · 2023-06-27T14:27:49Z

packages/server/tests/routes/bills.test.js

-      expecvt(res.body.errors).include.something.deep.equals({
+      expect(res.body.errors).include.something.deep.equals({


jsoref · 2023-06-27T16:07:29Z

packages/server/src/models/Account.ts

-   * Detarmines whether the given root type equals the account type.
+   * Determines whether the given root type equals the account type.


Note that this is Determines whereas the next one is Determine, I'm not sure why there's a divergence...

jsoref · 2023-06-27T16:09:32Z

packages/server/src/models/Account.ts

-   * Detarmine whether the given parent type equals the account type.
+   * Determine whether the given parent type equals the account type.


Note that this is Determine whereas the previous one is Determines, I'm not sure why there's a divergence...

jsoref · 2023-06-28T03:21:21Z

.../src/services/FinancialStatements/CashflowAccountTransactions/CashflowAccountTransactions.ts

-   *Transformes the account transaction to to cashflow transaction node.
+   *Transforms the account transaction to to cashflow transaction node.


there really should be a space after the *, but I'm not making changes like that...

jsoref · 2023-06-28T03:24:33Z

.../src/services/FinancialStatements/CashflowAccountTransactions/CashflowAccountTransactions.ts

@@ -39,7 +39,7 @@ export default class CashflowAccountTransactionReport extends FinancialSheet {
  }

  /**
-   *Transformes the account transaction to to cashflow transaction node.
+   *Transforms the account transaction to to cashflow transaction node.
   * @param {IAccountTransaction} transaction
   * @returns {ICashflowAccountTransaction}


JSDoc supports both @return and @returns, https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html#types, but it's probably best to use one of these two consistently and avoid using the other...

jsoref added 30 commits June 27, 2023 09:34

spelling: dialog

2d04e88

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dimension

a6db738

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dimensions

3586127

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dispatch

601939f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: display

a914f0e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dobounce

6da0f82

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: draggable

f301b4f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dropdown

b34dca9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dynamic

d76348a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: editable

0a884e3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: email

e02b2bf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: enterprise

82dc039

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: entries

5ecaf1c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: entry

747a28e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: environment

7d6b6a2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: equals

fef11d9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: equation

e55332d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: equity

483d134

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: errors

6db6e46

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: estimate

df2d278

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: estimated

27b5749

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: estimates

e7bfcff

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: evaluate

79a8963

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exchange

c38e812

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: execution

0d80a48

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exist

0dc58d7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: existence

e35bf21

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: existenceon

ccb3b1c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: expect

17adb17

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: expense

7c2db18

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 26 commits June 27, 2023 09:44

spelling: transfers

27ad1f5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transform

f2baed3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transformed

8f665de

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transformer

ca25838

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transformers

7301fb3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transforms

b49d75f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: triggers

fd97fad

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unauthorized

97e0794

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unique

15f3175

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: uniqueness

575c840

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: universal

bdf9a70

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unknown

8553ad4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unprocessable

ec4fb45

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsupported

1a3034f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: utils

92f9430

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: validate

2c4ee90

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: validates

10bc343

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: validation

e28b795

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

d0dbb52

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: vendor

c5c4ad8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: warehouse

3530170

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: warehousesitems

fb6cb3f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

3ab698a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: withdrawal

0db9668

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: wrap

1b5a12a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: written

c5a8691

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

vercel bot had a problem deploying to Preview June 27, 2023 14:08 Failure

abouolia self-assigned this Jun 27, 2023

jsoref commented Jun 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #178

Spelling #178

jsoref commented Jun 27, 2023

vercel bot commented Jun 27, 2023

jsoref left a comment

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 27, 2023

jsoref Jun 28, 2023

jsoref Jun 28, 2023

		- fixed: move `packaeg-lock.json` inside docker container.
		- fixed: move `package-lock.json` inside docker container.

		@@ -86,7 +86,7 @@ All notable changes to Bigcapital server-side will be in this file.

		## [0.8.3] - 06-04-2023

		`@bigcaptial/monorepo`

		"An account that holds valuation of products or goods that availiable for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",
		"An account that holds valuation of products or goods that available for sale.": "حساب يحمل قيم مخزون البضاعة أو السلع المتاحة للبيع.",

		expecvt(res.body.errors).include.something.deep.equals({
		expect(res.body.errors).include.something.deep.equals({

		* Detarmines whether the given root type equals the account type.
		* Determines whether the given root type equals the account type.

		* Detarmine whether the given parent type equals the account type.
		* Determine whether the given parent type equals the account type.

		*Transformes the account transaction to to cashflow transaction node.
		*Transforms the account transaction to to cashflow transaction node.

Spelling #178

Are you sure you want to change the base?

Spelling #178

Conversation

jsoref commented Jun 27, 2023

vercel bot commented Jun 27, 2023

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment