Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: fix numeric values in json enc #2402

Closed

Conversation

mbaraa
Copy link
Sponsor

@mbaraa mbaraa commented Mar 15, 2024

Description

Corresponding issue: #2401

Testing

I added more details in the issue #2401

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Apr 10, 2024
@1cg
Copy link
Contributor

1cg commented May 15, 2024

Can you please close this PR if it will break backwards compatibility? It looks like it would to me.

I would create a new extension and register it with the new extensions repo, https://github.com/bigskysoftware/htmx-extensions/ if you want a different JSON behavior.

@mbaraa
Copy link
Sponsor Author

mbaraa commented May 15, 2024

yeah, makes sense, I'll close the PR and create a new extension under https://github.com/bigskysoftware/htmx-extensions/

@mbaraa mbaraa closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants