Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fire htmx:trigger event on delayed triggers #2411

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/htmx.js
Original file line number Diff line number Diff line change
Expand Up @@ -1564,9 +1564,12 @@ return (function () {
}, triggerSpec.throttle);
}
} else if (triggerSpec.delay > 0) {
elementData.delayed = setTimeout(function() { handler(elt, evt) }, triggerSpec.delay);
elementData.delayed = setTimeout(function() {
triggerEvent(elt, 'htmx:trigger');
handler(elt, evt);
}, triggerSpec.delay);
} else {
triggerEvent(elt, 'htmx:trigger')
triggerEvent(elt, 'htmx:trigger');
handler(elt, evt);
}
}
Expand Down
17 changes: 17 additions & 0 deletions test/attributes/hx-trigger.js
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,23 @@ describe("hx-trigger attribute", function(){
}
});

it('fires the htmx:trigger event for delayed triggers', function (done) {
var param = "foo"
var handler = htmx.on("htmx:trigger", function (evt) {
param = "bar"
});
var div = make('<button hx-trigger="click delay:10ms">Submit</button>');
div.click();
setTimeout(function () {
try {
should.equal(param, "bar");
done();
} finally {
htmx.off("htmx:trigger", handler);
}
}, 50);
});

it('filters support "this" reference to the current element', function(){
this.server.respondWith("GET", "/test", "Called!");
var form = make('<form hx-get="/test" hx-trigger="click[this.classList.contains(\'bar\')]">Not Called</form>');
Expand Down