Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bodyContains() handle possibly nested shadow root's #2532

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

spez
Copy link

@spez spez commented May 5, 2024

Description

make bodyContains() handle the case where elt might be inside nested shadow dom's

Testing

Tested manually with and without nested shadow dom's

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@1cg
Copy link
Contributor

1cg commented May 15, 2024

no opinion on this @kgscialdone do you have one?

Definitely needs tests if it is to be accepted though.

@kgscialdone
Copy link
Contributor

This is... acceptable. Recursive checks like this are gross but there isn't really a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants