qa/suites/rbd/nvmeof: change gateway-name to host-name

[VallariAg]

ceph-nvmeof "listener add" cmd used arg "--gateway-name" in nvmeof:1.0.0 (see nvmeof_setup_subsystem.sh script).
This has been changed to "--host-name" in nvmeof:1.2.5

Following thing need to be done before merging this PR:

1. Change quay.io/ceph/nvmeof-cli:latest to point to tag 1.2.5 (right now it points to tag 1.0.0)
   Reason: Default nvmeof gateway image has been changed to 1.2.5 in mgr/cephadm: update default NVMEoF container image version #57182. Because teuthology tests use ceph's default gateway image + nvmeof-cli "latest" - there's a version mismatch of nvmeof gateway v1.2.5 and nvmeof-cli v1.0.0 in tests on main branch which causes error HA must be enabled for subsystems as seen in https://pulpito.ceph.com/dis-2024-05-16_08:07:49-rbd-wip-dis-testing-distro-default-smithi/7708811/
   (Tested the solution by running a test with both images using v1.2.5 and it was able to setup the subsystem)

2. Failing "nvme connect" test - "nvme list" it does not show any connected devices after doing a "nvme connect". It might be a bug in nvmeof, need to inspect.
   Seen in: https://pulpito.ceph.com/vallariag-2024-05-16_13:41:16-rbd:nvmeof-main-distro-default-smithi/

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

• When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows
• jenkins test rook e2e

[idryomov]

1. Change quay.io/ceph/nvmeof-cli:latest to point to tag 1.2.5 (right now it points to tag 1.0.0)

Is there someone looking into that? And separately, why isn't it happening automatically?

[VallariAg]

I have informed Aviv and Barak that it needs to be changed - we are looking into second issue right now.
@barakda would be able to give context about how the images are pushed and tagged.

[idryomov]

@barakda would be able to give context about how the images are pushed and tagged.

I would be interested in a justification for a backwards incompatible change to the CLI post 1.0.0 too.

[caroav]

@barakda would be able to give context about how the images are pushed and tagged.

I would be interested in a justification for a backwards incompatible change to the CLI post 1.0.0 too.

This change was made more than a month ago. We're not backwards compatible to 7.0 TP. What is the concern @idryomov ?

[idryomov]

What is the concern @idryomov ?

@caroav I'm asking from the upstream perspective. When the CLI overhaul was discussed, I thought it was decided that 1.0(.0) would be tagged and CLI would be declared stable, such that any future backwards incompatible change would need to pass a high bar. Do you have a different version for that base in mind?

[barakda]

I have informed Aviv and Barak that it needs to be changed - we are looking into second issue right now. @barakda would be able to give context about how the images are pushed and tagged.

a new tag version is pushed automatically through our github action (CI) when creating new release here
https://github.com/ceph/ceph-nvmeof/blob/06ef3a2cf9a75d1eefaaaed7bf8cf627b4aa2cec/.github/workflows/build-container.yml#L648
the latest tag is pushed manually as decided in the past.