ipam: lower loglevel from error to warn if eni link list can't be listed #32602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, failing attempts to obtain the eni link list while waiting for net link devices are logged as error. This leads to CI flakes due to the check `check-log-errors` in our test suite. ``` ❌ Found 1 logs in cilium-cilium-9121495685-1.us-west-1.eksctl.io/kube-system/cilium-vkddg (cilium-agent) matching list of errors that must be investigated: time="2024-05-17T01:39:54Z" level=error msg="failed to obtain eni link list" error="interrupted system call" subsys=ipam (1 occurrences) ``` Recent changes included this failure into the existing retry loop. Therefore it would be sufficient to log this failure as warning (instead of an error). Exceeding the retries would result in an error anyway. Therefore, this commit lowers the loglevel from `error` to `warn` and improves the log message by indicating the retry. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/enhancement
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, failing attempts to obtain the eni link list while waiting for net link devices are logged as error.
This leads to CI flakes due to the check
check-log-errorsin our test suite.(https://github.com/cilium/cilium/actions/runs/9121495685/job/25080745128)
Recent changes included this failure into the existing retry loop. Therefore it would be sufficient (and better (not only for CI but also the users), as this failure is kind of expected in some cases) to log this failure as warning (instead of an error). Exceeding the retries would result in an error anyway.
Therefore, this commit lowers the loglevel from
errortowarnand improves the log message by indicating the retry.Fixes: #32099