Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply permissions for any interpreter by specifying users or user groups in the configuration file. #3672

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ozlevka-work
Copy link

@ozlevka-work ozlevka-work commented Mar 20, 2024

What changes were proposed in this pull request?

  • Implement TODO label in function check_has_missing_permission.
  • After merge will allow to operator configure permissions for users or user group per interpreter

How was this patch tested

  • this patch tested manually and available with patched docker image ghcr.io/ozlevka-work/hue:v4.11.0-permissions.
  • will be glad to have any guidance for write automatic tests.

@ozlevka-work ozlevka-work changed the title Apply permissions for an interpreter by specifying users or user groups in the configuration file. Apply permissions for any interpreter by specifying users or user groups in the configuration file. Mar 20, 2024
@bjornalm
Copy link
Collaborator

Hi @ozlevka-work and thanks for the PR. I will assign this one to @agl29 and hopefully we can get it reviewed soon.

Copy link
Collaborator

@amitsrivastava amitsrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ozlevka-work thanks for the contribution.

Is the old db based permissions method not needed at all? Could this change break things for existing hue installations on upgrade?

@ozlevka-work
Copy link
Author

ozlevka-work commented Mar 27, 2024

Hi, @amitsrivastava
We use these connectors in our setup. I see that function called for any request.
If you not configure any permission you skip the check.
If I'm mistake could you please direct me to the documentation on how to connect HUE to ClickHouse using the new methods, including per-user/group permissions?

Copy link

github-actions bot commented Jun 2, 2024

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jun 2, 2024
@bjornalm bjornalm removed the Stale label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants