roachprod: use yaml for creating the cluster config #124322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameisbhaskar
requested review from
herkolategan and
vidit-bhat
and removed request for
a team
|
This change is |
nameisbhaskar
force-pushed
the
user/bhaskar/go-yaml-prom
branch
3 times, most recently
from
78e0f98
to
c549e7e
Compare
DarrylWong
reviewed
May 17, 2024
nameisbhaskar
force-pushed
the
user/bhaskar/go-yaml-prom
branch
2 times, most recently
from
b6d4dc8
to
8bbc5fd
Compare
nameisbhaskar
force-pushed
the
user/bhaskar/go-yaml-prom
branch
4 times, most recently
from
f40a1cc
to
e419a44
Compare
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
force-pushed
the
user/bhaskar/go-yaml-prom
branch
from
e419a44
to
0a22370
Compare
|
Thanks @DarrylWong @renatolabs |
|
bors r=@renatolabs @DarrylWong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky.
with this change, we are using go yaml to generate the yaml
Fixes: #124320
Epic: none