-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachprod: use go yaml to create the prometheus yaml #124320
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
nameisbhaskar
added
the
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
label
May 17, 2024
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 17, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 17, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 17, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 17, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 18, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 18, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 19, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 19, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 20, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
nameisbhaskar
added a commit
to nameisbhaskar/cockroach
that referenced
this issue
May 20, 2024
currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: cockroachdb#124320 Epic: none
craig bot
pushed a commit
that referenced
this issue
May 20, 2024
124322: roachprod: use yaml for creating the cluster config r=renatolabs a=nameisbhaskar currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky. with this change, we are using go yaml to generate the yaml Fixes: #124320 Epic: none Co-authored-by: Bhaskarjyoti Bora <bhaskar.bora@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Currently, we are using a template to generate the instance config target yaml file. The goal of this ticket is to use go yaml to generate the yaml file.
Jira issue: CRDB-38824
The text was updated successfully, but these errors were encountered: