Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachprod: use go yaml to create the prometheus yaml #124320

Closed
nameisbhaskar opened this issue May 17, 2024 · 0 comments · Fixed by #124322
Closed

roachprod: use go yaml to create the prometheus yaml #124320

nameisbhaskar opened this issue May 17, 2024 · 0 comments · Fixed by #124322
Assignees
@nameisbhaskar
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@nameisbhaskar
Copy link
Contributor

nameisbhaskar commented May 17, 2024 •
edited by cockroach-jira-scripts

Currently, we are using a template to generate the instance config target yaml file. The goal of this ticket is to use go yaml to generate the yaml file.

Jira issue: CRDB-38824
@nameisbhaskar nameisbhaskar added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 17, 2024
@nameisbhaskar nameisbhaskar self-assigned this May 17, 2024
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 17, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
f31520a 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
@nameisbhaskar nameisbhaskar mentioned this issue May 17, 2024
Merged
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 17, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
21ce3e7 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 17, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
78e0f98 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 17, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
c549e7e 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 18, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
b6d4dc8 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 18, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
8bbc5fd 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 19, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
c0fbabc 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 19, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
bcdab55 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 20, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
f40a1cc 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
nameisbhaskar added a commit to nameisbhaskar/cockroach that referenced this issue May 20, 2024
@nameisbhaskar
roachprod: use yaml for creating the cluster config
e419a44 
currently a template is used to generate the yaml for the
prometheus cluster config. this is error-prone and adding new
parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: cockroachdb#124320
Epic: none
craig bot pushed a commit that referenced this issue May 20, 2024
@nameisbhaskar
Merge #124322
e4d7442 
124322: roachprod: use yaml for creating the cluster config r=renatolabs a=nameisbhaskar

currently a template is used to generate the yaml for the prometheus cluster config. this is error-prone and adding new parameters also becomes risky.
with this change, we are using go yaml to generate the yaml

Fixes: #124320
Epic: none

Co-authored-by: Bhaskarjyoti Bora <bhaskar.bora@cockroachlabs.com>
@craig craig bot closed this as completed in 0a22370 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nameisbhaskar nameisbhaskar

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachprod: use yaml for creating the cluster config nameisbhaskar/cockroach
1 participant
@nameisbhaskar