Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update value as needed and reuse variables #16984

Merged
merged 2 commits into from
May 24, 2024

Conversation

minggo
Copy link
Contributor

@minggo minggo commented May 13, 2024

Re: #16952

Changelog

  • reuse local variable
  • use static method of Vec3.set() and Quat.set() as they don't have to distinguish variable types, so they are more efficient
  • make Node.setWorldPosition(), Node.setWorldRotation(), Node.setWorldRotationFromEuler(), Node.setWorldScale() update values add needed

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@minggo minggo requested a review from dumganhar May 13, 2024 08:14
@minggo minggo marked this pull request as draft May 13, 2024 08:15
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@minggo minggo marked this pull request as ready for review May 13, 2024 08:53
@minggo
Copy link
Contributor Author

minggo commented May 21, 2024

@cocos-robot run test cases

@minggo
Copy link
Contributor Author

minggo commented May 23, 2024

@cocos-robot run test cases

@minggo minggo merged commit c4b14be into cocos:v3.8.5 May 24, 2024
21 of 22 checks passed
@minggo minggo deleted the node-setter-improve branch May 24, 2024 01:26
Copy link

@minggo ❗ There was an error during the execution of the tasks. Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants