Copy field values from other sites #14056
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/controllers/ElementsController.php # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/cp/src/js/ElementEditor.js
…py-field-values-from-other-sites
…:craftcms/cms into feature/cms-979-copy-field-values-from-other-sites
brianjhanson
force-pushed
the
feature/cms-979-copy-field-values-from-other-sites
branch
from
1458c2b
to
7e90323
Compare
brianjhanson
force-pushed
the
feature/cms-979-copy-field-values-from-other-sites
branch
from
7e90323
to
3c2a490
Compare
The primary gain here is that we don't need to re-initialize them after replacing DOM elements
The primary gain here is that we don't need to re-initialize them after replacing DOM elements
brianjhanson
changed the title
1 task
|
I think this was "missing piece" of multi-language functionality of Craft CMS. Thanks for adding this. |
I concur; really looking forward to seeing it merged. Any chance it'll make it into 5.2? 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12436 but instead of handling the copy server-side, the controller will return fragments of HTML that we use to replace fields and immediately save a draft. This simplifies the logic a bit as we can rely on existing "Save Draft" processes to save the values.
Description
On the entry/category edit page (elements that support autosaving drafts):
copy action is applied to the top-level fields (e.g. entire matrix field)
IMPORTANT: once this feature is released, an update to craftcms/html-field needs to be released; craftcms/html-field#6
CleanShot.2023-12-19.at.13.44.44.mp4