Feature/cms 1091 ability to move entries to a new section

[i-just]

Description

Adds element index action to move entries between sections.

• select entries to be moved and trigger the “Move to” action

• see a modal with a list of compatible sections (sections that have the same entry type(s) as the entries we want to move)

• choose a section to move to
• entries are moved to the new section

Notes:

• it’s not possible to move to a single section
• for structures, entries are moved to the end of the new structure as root elements
• if the section entries are moved to has a lower maxAuthors limit, no data is changed/lost for the entries, but the next time they’re saved, a validation error will be shown
• when an entry is moved, its revisions and drafts are moved too; if their entry type isn’t allowed by the section we’re moving to, you will still be able to see the draft/revision but not apply/revert to it (the same applies to revisions and draft for entry types that were removed from the section); thanks @brianjhanson for adjusting the awesome craft-tooltip to work with disabled elements!

Related issues

cms-1091

[linear]

CMS-1091 Ability to move entries to a new section

[brandonkelly]

Rather than showing the “Couldn’t find any sections that all selected elements could be moved to.” message in the modal, ideally the “Move to” action is just grayed out ahead of time if there aren’t any other sections with the same entry type.

This should be doable via the validateSelection() method on the action trigger JS.

[gcamacho079]

Just finished a quick scan of the modal contents:

• The section buttons should have an aria-pressed value that toggles between true and false (see internal documentation re: exclusive button groups)
• The Move button's aria-disabled state should be toggled when a section is selected
• The focus indicator for the move icon is under 3:1 contrast ratio against the modal footer background. This is a larger global issue caused by the disabled element opacity.
• The focus indicator for the button is difficult to see since it doesn’t contrast against the dark background. This could benefit from a two-toned focus indicator, like the one used in the global skip link, with a white outline adjacent to the button background.
• Loading spinner that appears in modal content body should have an equivalent status message that is read for screen reader users.

Note that some of these (like the disabled button focus outline) may be larger/more global issues than the scope of this PR.

[i-just]

@gcamacho079, as per our chats, all items except the disabled button focus ring are actioned.

To get the last item from the list to work, I added the live region container and updateLiveRegion method to all modals (via Garnish.Modal) and started using it in my EntryMover, which means other modals could start taking advantage of it.

[brandonkelly]

ElementsController shouldn’t be giving any special treatment to entries, so we’ll need to rethink how we do this.

[i-just]

ok; addressed here: f86e782

[brandonkelly]

It seems a little weird to introduce the concept of “moving” to all element types, when entries are the only one that would actually know what to do with it.

[i-just]

As per our chat, this might end up being a way to go.
But, for now, I have reverted those changes and used a different approach where I added the ability to further customise element chip & card attributes, and I’m adding data-movable via those.