Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/15000 component chips #15017

Merged
merged 6 commits into from
May 22, 2024
Merged

Bugfix/15000 component chips #15017

merged 6 commits into from
May 22, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented May 17, 2024

Description

  1. I adjusted the width of .chip-content for the component chips. (I also verified that the entry author chip still doesn’t overflow with this change.)

Before:
Screenshot 2024-05-17 at 08 37 02

After:
Screenshot 2024-05-17 at 08 36 46

  1. I also noticed that the datetime clear button was overflowing on smaller viewports. To fix this, I removed the right margin. Added bonus - the clear button now aligns with the actions menu dots in the entry's meta panel.

Before:
Screenshot 2024-05-17 at 08 38 05

After:
Screenshot 2024-05-17 at 08 38 17
Screenshot 2024-05-17 at 08 37 39

Related issues

#15000

@i-just i-just requested a review from brandonkelly May 17, 2024 07:44
@brandonkelly
Copy link
Member

@i-just This change is conflicting with #14999. Can you merge 5.x into this branch and resolve that conflict?

@i-just
Copy link
Contributor Author

i-just commented May 20, 2024

Sure, done!

@brandonkelly brandonkelly merged commit 8a4f657 into 5.x May 22, 2024
@brandonkelly brandonkelly deleted the bugfix/15000-component-chips branch May 22, 2024 17:12
@brandonkelly
Copy link
Member

Looks great, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants