Fix Perf Test Regression #7677
Fix Perf Test Regression #7677
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
|
👋 @cicoyle, my apologies but I can't perform this action for you because your username is not in the allowlist in the file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7677 +/- ##
==========================================
+ Coverage 56.99% 61.80% +4.80%
==========================================
Files 477 245 -232
Lines 25809 22420 -3389
==========================================
- Hits 14711 13856 -855
+ Misses 9937 7400 -2537
- Partials 1161 1164 +3 ☔ View full report in Codecov by Sentry. |
|
/ok-to-perf |
Dapr perf testCommit ref: 8659561 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
Dapr perf testCommit ref: 453f17f ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
Dapr perf testCommit ref: 0801a83 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
Dapr perf testCommit ref: 25fea4b ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
|
/ok-to-perf |
Dapr perf testCommit ref: 25fea4b ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
…rialization from release1.13 Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
Dapr perf testCommit ref: d17d61a ✅ Build succeeded
✅ Infrastructure deployed
✅ Perf tests succeeded
|
cicoyle
changed the title
|
/ok-to-perf |
Dapr perf testCommit ref: d3224b2 ✅ Build succeeded
✅ Infrastructure deployed
✅ Perf tests succeeded
|
|
Maybe that unit test for placement membership is flaky? |
|
/ok-to-perf |
Dapr perf testCommit ref: d3224b2 ✅ Build succeeded
✅ Infrastructure deployed
✅ Perf tests succeeded
|
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
|
/ok-to-perf |
Dapr perf testCommit ref: 55f567c ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
|
@cicoyle you can use |
|
/ok-to-perf actor_reminder |
Dapr perf testCommit ref: f6690c0 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
|
/ok-to-perf actor_reminder |
1 similar comment
|
/ok-to-perf actor_reminder |
Dapr perf testCommit ref: 03e41c1 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
Dapr perf testCommit ref: 03e41c1 ✅ Build succeeded
✅ Infrastructure deployed
❌ Perf tests failedPlease check the logs for details on the error. |
|
Looks like there is a panic with |
Signed-off-by: Mike Nguyen <hey@mike.ee>
|
/ok-to-perf |
Dapr perf testCommit ref: 81727ba ✅ Build succeeded
✅ Infrastructure deployed
✅ Perf tests succeeded
|
|
/ok-to-perf |
Dapr perf testCommit ref: 81727ba ✅ Infrastructure deployed
✅ Build succeeded
|
There was a problem hiding this comment.
https://github.com/dapr/dapr/blob/81727bab7306e8e0b68393a4d91434b9762b7611/pkg/api/http/responses.go
Nit would be to remove this dead code to make the linter happy
|
This was already merged in, so going to close this. |
Reverting the changes from this PR updating actor code: update master w/ release-1.13 branch changes resulted in the perf tests passing again, specifically the
TestActorReminderRegistrationPerformancetest.The changes involve reverting the: json serialization and api level.