Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Integration: Remove framework/util #7688

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

JoshVanL
Copy link
Contributor

Removes poorly named framework/util package. Moves daprd Metadata calls to direct daprd framework process calls.

@JoshVanL JoshVanL requested review from a team as code owners April 11, 2024 11:39
@JoshVanL JoshVanL added the autoupdate DaprBot will keep the Pull Request up to date with master branch label Apr 11, 2024
@yaron2
Copy link
Member

yaron2 commented Apr 18, 2024

Linter is failing

@JoshVanL JoshVanL force-pushed the test-integration-remove-util branch from ca365cd to 9c1042a Compare April 18, 2024 23:11
@JoshVanL JoshVanL force-pushed the test-integration-remove-util branch 2 times, most recently from 73de94c to b992bb1 Compare May 7, 2024 16:40
daixiang0
daixiang0 previously approved these changes May 14, 2024
@daixiang0
Copy link
Member

@JoshVanL please fix conflicts.

Removes poorly named `framework/util` package. Moves daprd Metadata
calls to direct daprd framework process calls.

Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
@artursouza artursouza added the automerge Allows DaprBot to automerge and update PR if all approvals are in place label May 25, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.98%. Comparing base (199bcf4) to head (484a19e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7688    +/-   ##
========================================
  Coverage   56.98%   56.98%            
========================================
  Files         477      480     +3     
  Lines       25809    25982   +173     
========================================
+ Hits        14707    14806    +99     
- Misses       9940     9999    +59     
- Partials     1162     1177    +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allows DaprBot to automerge and update PR if all approvals are in place autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants