Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension-teal tests to the editor #8939

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

matgis
Copy link
Contributor

@matgis matgis commented May 16, 2024

Technical changes

  • Added editor tests for extension-teal.
  • In dev builds of the editor, JVM properties will be injected into URL setting values.
  • Dependency URLs for official extensions are now injected as JVM properties in the format defold.extension.teal.url=https://... defined in project.clj into editor test projects.
  • In dev builds of the editor JVM properties in the format defold.extension.teal.path=/Users/.../Repos/extension-teal will cause the editor to use the contents of the specified directory in place of the corresponding defold.extension.*.url when fetching libraries.
  • When registering resource types, you can now specify :built-pb-class <ProtobufMessageClass> to aid test functions such as test-util/make-build-output-infos-by-path to deserialize built binaries into Clojure maps.

vlaaad
vlaaad previously approved these changes May 20, 2024
Copy link
Contributor

@vlaaad vlaaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the test suite! 🔥

editor/src/clj/editor/protobuf.clj Outdated Show resolved Hide resolved
Copy link
Contributor

@vlaaad vlaaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matgis matgis merged commit e0ff93b into dev May 20, 2024
22 checks passed
@matgis matgis deleted the DEF-8291-extension-teal-tests branch May 20, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants