Skip to content

Commit

Permalink
chore: deno_core bump (#22379)
Browse files Browse the repository at this point in the history
- Updates to V8 12.1.285.27

denoland/rusty_v8#1383

 - Swaps Box for Rc for `source_map_getter`
  • Loading branch information
mmastrac committed Feb 11, 2024
1 parent f5e46c9 commit 26d9b2f
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ repository = "https://github.com/denoland/deno"

[workspace.dependencies]
deno_ast = { version = "0.33.2", features = ["transpiling"] }
deno_core = { version = "0.260.0" }
deno_core = { version = "0.261.0" }

deno_bench_util = { version = "0.131.0", path = "./bench_util" }
deno_lockfile = "0.18.2"
Expand Down
4 changes: 2 additions & 2 deletions cli/module_loader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,8 @@ impl ModuleLoaderFactory for CliModuleLoaderFactory {
)
}

fn create_source_map_getter(&self) -> Option<Box<dyn SourceMapGetter>> {
Some(Box::new(CliSourceMapGetter {
fn create_source_map_getter(&self) -> Option<Rc<dyn SourceMapGetter>> {
Some(Rc::new(CliSourceMapGetter {
shared: self.shared.clone(),
}))
}
Expand Down
2 changes: 1 addition & 1 deletion cli/standalone/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ impl ModuleLoaderFactory for StandaloneModuleLoaderFactory {
fn create_source_map_getter(
&self,
) -> Option<Box<dyn deno_core::SourceMapGetter>> {
) -> Option<Rc<dyn deno_core::SourceMapGetter>> {
None
}
}
Expand Down
2 changes: 1 addition & 1 deletion cli/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub trait ModuleLoaderFactory: Send + Sync {
dynamic_permissions: PermissionsContainer,
) -> Rc<dyn ModuleLoader>;

fn create_source_map_getter(&self) -> Option<Box<dyn SourceMapGetter>>;
fn create_source_map_getter(&self) -> Option<Rc<dyn SourceMapGetter>>;
}

// todo(dsherret): this is temporary and we should remove this
Expand Down
2 changes: 1 addition & 1 deletion runtime/web_worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ pub struct WebWorkerOptions {
pub npm_resolver: Option<Arc<dyn deno_node::NpmResolver>>,
pub create_web_worker_cb: Arc<ops::worker_host::CreateWebWorkerCb>,
pub format_js_error_fn: Option<Arc<FormatJsErrorFn>>,
pub source_map_getter: Option<Box<dyn SourceMapGetter>>,
pub source_map_getter: Option<Rc<dyn SourceMapGetter>>,
pub worker_type: WebWorkerType,
pub maybe_inspector_server: Option<Arc<InspectorServer>>,
pub get_error_class_fn: Option<GetErrorClassFn>,
Expand Down
2 changes: 1 addition & 1 deletion runtime/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ pub struct WorkerOptions {
pub format_js_error_fn: Option<Arc<FormatJsErrorFn>>,

/// Source map reference for errors.
pub source_map_getter: Option<Box<dyn SourceMapGetter>>,
pub source_map_getter: Option<Rc<dyn SourceMapGetter>>,
pub maybe_inspector_server: Option<Arc<InspectorServer>>,
// If true, the worker will wait for inspector session and break on first
// statement of user code. Takes higher precedence than
Expand Down

0 comments on commit 26d9b2f

Please sign in to comment.