Skip to content

Commit

Permalink
Cherry-pick version bump commit with conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
denobot authored and dsherret committed May 18, 2024
1 parent 1a0fbc4 commit 65e79fa
Show file tree
Hide file tree
Showing 16 changed files with 483 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import { stringify } from "jsr:@std/yaml@^0.221/stringify";
// Bump this number when you want to purge the cache.
// Note: the tools/release/01_bump_crate_versions.ts script will update this version
// automatically via regex, so ensure that this line maintains this format.
<<<<<<< HEAD
const cacheVersion = 91;
=======
const cacheVersion = 92;
>>>>>>> a13c4531f (1.43.5 (#23876))

const ubuntuX86Runner = "ubuntu-22.04";
const ubuntuX86XlRunner = "ubuntu-22.04-xl";
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,13 @@ jobs:
path: |-
~/.cargo/registry/index
~/.cargo/registry/cache
<<<<<<< HEAD
key: '91-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-${{ hashFiles(''Cargo.lock'') }}'
restore-keys: '91-cargo-home-${{ matrix.os }}-${{ matrix.arch }}'
=======
key: '92-cargo-home-${{ matrix.os }}-${{ matrix.arch }}-${{ hashFiles(''Cargo.lock'') }}'
restore-keys: '92-cargo-home-${{ matrix.os }}-${{ matrix.arch }}'
>>>>>>> a13c4531f (1.43.5 (#23876))
if: '!(matrix.skip)'
- name: Restore cache build output (PR)
uses: actions/cache/restore@v4
Expand All @@ -380,7 +385,11 @@ jobs:
!./target/*/*.zip
!./target/*/*.tar.gz
key: never_saved
<<<<<<< HEAD
restore-keys: '91-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-'
=======
restore-keys: '92-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-'
>>>>>>> a13c4531f (1.43.5 (#23876))
- name: Apply and update mtime cache
if: '!(matrix.skip) && (!startsWith(github.ref, ''refs/tags/''))'
uses: ./.github/mtime_cache
Expand Down Expand Up @@ -669,7 +678,11 @@ jobs:
!./target/*/gn_out
!./target/*/*.zip
!./target/*/*.tar.gz
<<<<<<< HEAD
key: '91-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
=======
key: '92-cargo-target-${{ matrix.os }}-${{ matrix.arch }}-${{ matrix.profile }}-${{ matrix.job }}-${{ github.sha }}'
>>>>>>> a13c4531f (1.43.5 (#23876))
publish-canary:
name: publish canary
runs-on: ubuntu-22.04
Expand Down
11 changes: 11 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ deno_crypto = { version = "0.166.0", path = "./ext/crypto" }
deno_fetch = { version = "0.176.0", path = "./ext/fetch" }
deno_ffi = { version = "0.139.0", path = "./ext/ffi" }
deno_fs = { version = "0.62.0", path = "./ext/fs" }
<<<<<<< HEAD
deno_http = { version = "0.150.0", path = "./ext/http" }
=======
deno_http = { version = "0.149.0", path = "./ext/http" }
>>>>>>> a13c4531f (1.43.5 (#23876))
deno_io = { version = "0.62.0", path = "./ext/io" }
deno_kv = { version = "0.60.0", path = "./ext/kv" }
deno_napi = { version = "0.82.0", path = "./ext/napi" }
Expand Down
7 changes: 7 additions & 0 deletions Releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ https://github.com/denoland/deno/releases
We also have one-line install commands at:
https://github.com/denoland/deno_install

<<<<<<< HEAD
=======
### 1.43.5 / 2024.05.18

- fix(npm): regression deserializing JSON for some npm packages (#23868)

>>>>>>> a13c4531f (1.43.5 (#23876))
### 1.43.4 / 2024.05.16

- fix(cli): panic with `deno coverage` (#23353)
Expand Down
4 changes: 4 additions & 0 deletions cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

[package]
name = "deno"
<<<<<<< HEAD
version = "1.43.4"
=======
version = "1.43.5"
>>>>>>> a13c4531f (1.43.5 (#23876))
authors.workspace = true
default-run = "deno"
edition.workspace = true
Expand Down
26 changes: 26 additions & 0 deletions cli/args/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ use serde::Serialize;
use std::env;
use std::ffi::OsString;
use std::net::SocketAddr;
<<<<<<< HEAD
=======
use std::num::NonZeroU16;
>>>>>>> a13c4531f (1.43.5 (#23876))
use std::num::NonZeroU32;
use std::num::NonZeroU8;
use std::num::NonZeroUsize;
Expand Down Expand Up @@ -282,7 +286,11 @@ impl RunFlags {
pub struct ServeFlags {
pub script: String,
pub watch: Option<WatchFlagsWithPaths>,
<<<<<<< HEAD
pub port: u16,
=======
pub port: NonZeroU16,
>>>>>>> a13c4531f (1.43.5 (#23876))
pub host: String,
}

Expand All @@ -292,7 +300,11 @@ impl ServeFlags {
Self {
script,
watch: None,
<<<<<<< HEAD
port,
=======
port: NonZeroU16::new(port).unwrap(),
>>>>>>> a13c4531f (1.43.5 (#23876))
host: host.to_owned(),
}
}
Expand Down Expand Up @@ -2463,8 +2475,13 @@ fn serve_subcommand() -> Command {
.arg(
Arg::new("port")
.long("port")
<<<<<<< HEAD
.help("The TCP port to serve on, defaulting to 8000. Pass 0 to pick a random free port.")
.value_parser(value_parser!(u16)),
=======
.help("The TCP port to serve on, defaulting to 8000.")
.value_parser(value_parser!(NonZeroU16)),
>>>>>>> a13c4531f (1.43.5 (#23876))
)
.arg(
Arg::new("host")
Expand Down Expand Up @@ -4126,7 +4143,13 @@ fn serve_parse(
app: Command,
) -> clap::error::Result<()> {
// deno serve implies --allow-net=host:port
<<<<<<< HEAD
let port = matches.remove_one::<u16>("port").unwrap_or(8000);
=======
let port = matches
.remove_one::<NonZeroU16>("port")
.unwrap_or(NonZeroU16::new(8000).unwrap());
>>>>>>> a13c4531f (1.43.5 (#23876))
let host = matches
.remove_one::<String>("host")
.unwrap_or_else(|| "0.0.0.0".to_owned());
Expand Down Expand Up @@ -5319,6 +5342,7 @@ mod tests {
..Flags::default()
}
);
<<<<<<< HEAD

let r = flags_from_vec(svec![
"deno",
Expand All @@ -5345,6 +5369,8 @@ mod tests {
..Flags::default()
}
);
=======
>>>>>>> a13c4531f (1.43.5 (#23876))
}

#[test]
Expand Down
8 changes: 8 additions & 0 deletions cli/args/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ use std::env;
use std::io::BufReader;
use std::io::Cursor;
use std::net::SocketAddr;
<<<<<<< HEAD
=======
use std::num::NonZeroU16;
>>>>>>> a13c4531f (1.43.5 (#23876))
use std::num::NonZeroUsize;
use std::path::Path;
use std::path::PathBuf;
Expand Down Expand Up @@ -1035,7 +1039,11 @@ impl CliOptions {
}
}

<<<<<<< HEAD
pub fn serve_port(&self) -> Option<u16> {
=======
pub fn serve_port(&self) -> Option<NonZeroU16> {
>>>>>>> a13c4531f (1.43.5 (#23876))
if let DenoSubcommand::Serve(flags) = self.sub_command() {
Some(flags.port)
} else {
Expand Down
12 changes: 12 additions & 0 deletions cli/worker.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

<<<<<<< HEAD
=======
use std::num::NonZeroU16;
>>>>>>> a13c4531f (1.43.5 (#23876))
use std::path::Path;
use std::path::PathBuf;
use std::rc::Rc;
Expand Down Expand Up @@ -147,7 +151,11 @@ struct SharedWorkerState {
disable_deprecated_api_warning: bool,
verbose_deprecated_api_warning: bool,
code_cache: Option<Arc<dyn code_cache::CodeCache>>,
<<<<<<< HEAD
serve_port: Option<u16>,
=======
serve_port: Option<NonZeroU16>,
>>>>>>> a13c4531f (1.43.5 (#23876))
serve_host: Option<String>,
}

Expand Down Expand Up @@ -417,7 +425,11 @@ impl CliMainWorkerFactory {
feature_checker: Arc<FeatureChecker>,
options: CliMainWorkerOptions,
node_ipc: Option<i64>,
<<<<<<< HEAD
serve_port: Option<u16>,
=======
serve_port: Option<NonZeroU16>,
>>>>>>> a13c4531f (1.43.5 (#23876))
serve_host: Option<String>,
enable_future_features: bool,
disable_deprecated_api_warning: bool,
Expand Down
6 changes: 6 additions & 0 deletions ext/http/00_serve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -793,9 +793,15 @@ internals.serveHttpOnConnection = serveHttpOnConnection;

function registerDeclarativeServer(exports) {
if (ObjectHasOwn(exports, "fetch")) {
<<<<<<< HEAD
if (typeof exports.fetch !== "function") {
throw new TypeError(
"Invalid type for fetch: must be a function with a single or no parameter",
=======
if (typeof exports.fetch !== "function" || exports.fetch.length !== 1) {
throw new TypeError(
"Invalid type for fetch: must be a function with a single parameter",
>>>>>>> a13c4531f (1.43.5 (#23876))
);
}
return ({ servePort, serveHost }) => {
Expand Down
4 changes: 4 additions & 0 deletions ext/http/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

[package]
name = "deno_http"
<<<<<<< HEAD
version = "0.150.0"
=======
version = "0.149.0"
>>>>>>> a13c4531f (1.43.5 (#23876))
authors.workspace = true
edition.workspace = true
license.workspace = true
Expand Down

0 comments on commit 65e79fa

Please sign in to comment.