Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(workers): importScripts concurrently and use a new reqwest::Client per importScripts #23699

Merged
merged 2 commits into from May 5, 2024
Merged

fix(workers): importScripts concurrently and use a new reqwest::Client per importScripts #23699

merged 2 commits into from May 5, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 5, 2024 •
edited

  1. We were polling each future in sequence, so this meant it was fetching scripts in sequence.
  2. It's not safe to share reqwest::Client across tokio runtimes (dispatch dropped without returning error seanmonstar/reqwest#1148 (comment))

mmastrac
mmastrac approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit d527b63 into denoland:main May 5, 2024
17 checks passed
@dsherret dsherret deleted the fix_importScripts_concurrent branch May 5, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @mmastrac