Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): error when throwing FS_EISDIR #23829

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(node): error when throwing FS_EISDIR #23829

merged 1 commit into from
May 16, 2024

Conversation

marvinhagemeister
Copy link
Contributor

The EISDIR error code is not available as a global variable, but must be accessed through the osConstants.errno object.

Fixes #23695

@marvinhagemeister marvinhagemeister merged commit 00e6d41 into main May 16, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the constant-access branch May 16, 2024 08:30
bartlomieju pushed a commit that referenced this pull request May 16, 2024
@marvinhagemeister @bartlomieju
fix(node): error when throwing FS_EISDIR (#23829)
10ce4b1 
The `EISDIR` error code is not available as a global variable, but must
be accessed through the `osConstants.errno` object.

Fixes #23695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: EISDIR is not defined | node pollyfill is missing a constant
2 participants
@marvinhagemeister @bartlomieju