Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying modified patches from FreeBSD ports (www/deno/files) #1483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Munrok
Copy link

@Munrok Munrok commented May 16, 2024

Patches from FreeBSD port tree been modified to fit current state of repository and were applied.
Source of original patch files https://github.com/freebsd/freebsd-ports/tree/main/www/deno/files
Subset of patches used: patch-cargo-crates_v8_*

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

@Munrok
Copy link
Author

Munrok commented May 17, 2024

I see that some checks were aborted after dozen of seconds. Does it mean additional work should be done in order to prepare version that can go further in checking process?

@bartlomieju
Copy link
Member

@Munrok the whole build process requires various directories to be pulled from repos like https://github.com/denoland/chromium_build.git or https://github.com/denoland/v8.git. If you'd like to upstream your changes you'll need to open PR against these repos. That said, I'm not super happy to float several patches in V8 or abseil. Have you tried opening CL against upstream repos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants