Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use docopt.go import which should be ok since Go 1.13 #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wallyqs
Copy link

@wallyqs wallyqs commented Sep 7, 2020

Updated the repository to use github.com/docopt/docopt.go which since version Go 1.13 should work ok with Go modules (I know because other project I help maintain nats.go was one of the first projects ending with .go being able to use this approach without issues 😅 )

Signed-off-by: Waldemar Quevedo wally@synadia.com

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.261% when pulling 8d0f41e on wallyqs:updates2020 into ee0de3b on docopt:master.

@wallyqs wallyqs changed the title Update to use docopt.go import which should be ok now Update to use docopt.go import which should be ok since Go 1.13 Sep 7, 2020
@c4milo
Copy link

c4milo commented Jan 5, 2021

@mboersma ping

@wallyqs
Copy link
Author

wallyqs commented Jan 6, 2021

Closing since seems that project is not maintained anymore, but this should be fine in case someone wants to pick this up.

@wallyqs wallyqs closed this Jan 6, 2021
@mboersma
Copy link
Member

mboersma commented Jan 6, 2021

@wallyqs my apologies for not following up! You're right that the project is unmaintained now, and I'm reluctant to make any changes that would imply it's still supported.

I still think docopt is a groovy idea, but the project founder has moved on and none of us have been able to contact him for years. 😞

@wallyqs
Copy link
Author

wallyqs commented Jan 6, 2021

@mboersma no worries! I liked docopt since it was great for prototyping when using it in Ruby, thanks for the reply :)

@wallyqs wallyqs reopened this Oct 14, 2021
@wallyqs wallyqs mentioned this pull request Oct 14, 2021
@shakefu
Copy link

shakefu commented Nov 10, 2021

Would be great to add 1.16 and 1.17 to CI with this PR as well @wallyqs

@shakefu
Copy link

shakefu commented Nov 10, 2021

@oprypin This looks safe to merge targeting a 1.x release and deprecating pre-module Go along with #80.

@wallyqs
Copy link
Author

wallyqs commented Nov 10, 2021

@shakefu thanks, just added 👍

@oprypin oprypin self-requested a review November 11, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants