Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue dependencies, tests, and documentation. Fix text interpolation in code blocks. #2430

Merged
merged 7 commits into from
May 19, 2024

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented May 17, 2024

Summary

  • Remove Vue v2 dependencies, tests, and documentation
    Vue.js v2 has reached EOL status.

  • Update Vue v3 dependencies, tests, and documentation

  • Support Vue text interpolation in code blocks
    See Vue template doesn't work in markdown code block. #1812 for details. This is now supported by wrapping a code block in an element with a v-template attribute:

    <div v-template>
    
    ```
    {{ message}}
    ```
    
    </div>

Related issue, if any:

#1812

What kind of change does this PR introduce?

Bugfix (in docs)
Build-related changes
Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:58pm

@jhildenbiddle jhildenbiddle added this to the 5.x milestone May 17, 2024
@jhildenbiddle jhildenbiddle requested a review from a team May 17, 2024 18:44
@jhildenbiddle jhildenbiddle changed the title Update Vue.js v3 and remove v2 dependencies, tests, and documentation Update Vue dependencies, tests, and documentation. Fix text interpolation in code blocks. May 17, 2024
@jhildenbiddle jhildenbiddle linked an issue May 17, 2024 that may be closed by this pull request
1 task
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Koooooo-7 Koooooo-7 requested a review from a team May 19, 2024 09:25
@jhildenbiddle jhildenbiddle merged commit 8ef9a3c into develop May 19, 2024
9 checks passed
@jhildenbiddle jhildenbiddle deleted the vue-update branch May 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue template doesn't work in markdown code block.
3 participants