Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for tilting the cursor when italicized #1932

Merged
merged 4 commits into from
Jun 1, 2024
Merged

feat: support for tilting the cursor when italicized #1932

merged 4 commits into from
Jun 1, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 16, 2024 •
edited

  • support for tilting the cursor when italicized
  • Text Range use the system highlight color

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 27.10%. Comparing base (1169af4) to head (015830c).
Report is 1 commits behind head on dev.

Files Patch % Lines
...r/src/components/docs/text-selection/text-range.ts 0.00% 19 Missing ⚠️
packages/engine-render/src/basics/tools.ts 0.00% 10 Missing ⚠️
...cs/text-selection/text-selection-render-manager.ts 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1932      +/-   ##
==========================================
- Coverage   27.11%   27.10%   -0.01%     
==========================================
  Files        1645     1645              
  Lines       82933    82963      +30     
  Branches    17184    17189       +5     
==========================================
  Hits        22486    22486              
- Misses      60447    60477      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review April 17, 2024 03:52
@Jocs Jocs requested a review from lumixraku as a code owner April 22, 2024 00:07
@Jocs Jocs merged commit ac62428 into dev Jun 1, 2024
9 checks passed
@Jocs Jocs deleted the feat/cursor-italic branch June 1, 2024 09:29
ybzky pushed a commit that referenced this pull request Jun 1, 2024
@Jocs @ybzky
feat: support for tilting the cursor when italicized (#1932)
e4080cc 
* feat: support for tilting the cursor when italicized

* feat: add system highlight color as seleciton color

* fix: stroke width

* fix: add default value of opacity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer DR-Univer is a code owner

@lumixraku lumixraku Awaiting requested review from lumixraku lumixraku is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jocs @wzhudev