Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render-engine): optimize underline postion #2164

Merged
merged 2 commits into from
May 31, 2024
Merged

fix(render-engine): optimize underline postion #2164

merged 2 commits into from
May 31, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 6, 2024

close #1860

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 29.25%. Comparing base (a98e8ab) to head (2428d80).
Report is 2 commits behind head on dev.

Files Patch % Lines
...gine-render/src/components/docs/extensions/line.ts 0.00% 11 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2164      +/-   ##
==========================================
- Coverage   29.26%   29.25%   -0.02%     
==========================================
  Files        1516     1516              
  Lines       76736    76737       +1     
  Branches    15942    15940       -2     
==========================================
- Hits        22457    22447      -10     
- Misses      54279    54290      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review May 6, 2024 09:19
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo
Copy link

oumomomo commented May 6, 2024

上标的下划线位置太下
image

@univer-bot
Copy link

univer-bot bot commented May 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

The superscript and underline are too far down
image

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels May 6, 2024
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels May 31, 2024
@Jocs Jocs merged commit b0ccb91 into dev May 31, 2024
9 checks passed
@Jocs Jocs deleted the fix/underline branch May 31, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The position of the subscript and underline in the document is inconsistent
3 participants