Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multirange data wire #6468

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add multirange data wire #6468

wants to merge 4 commits into from

Conversation

diksipav
Copy link
Contributor

@diksipav diksipav commented Nov 14, 2023

First commit is addition of multirange section.
In the 2nd commit I removed "The" from many places it seemed a bit weird. I consulted @raddevon and he agrees it was a bit weird, but pls let me know if u think we should leave "The" in the sentences @elprans @1st1 . I can easily revert that commit.

Copy link
Contributor

@raddevon raddevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Reads much more naturally without the articles. 👍

@nsidnev
Copy link
Member

nsidnev commented Nov 14, 2023

It seems to me that in addition to the wire format for MultiRange, this PR should include a description of its descriptor as well

@elprans
Copy link
Member

elprans commented Dec 15, 2023

@diksipav Looks like @Dhghomon beat you with article cleanup in #6564. Please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants