Only decode url encoded slashes in db/branch name after splitting path into parts #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetrovykh
pushed a commit
that referenced
this pull request
May 21, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
May 22, 2024
vpetrovykh
added
backported-5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the branch/db name contains
/characters, they need to be url encoded in the url path for the http apis's. Currently the encoded slashes are decoded before the path is split into parts, so only the first part of the name before the first/is used as the branch name, and the rest just breaks further routing.Since the branch name is the only part of the path that is user defined and can contain
/characters, do the url decoding only on the branch part of the path after splitting.Related issue: edgedb/edgedb-ui#352