Refresh tracer metadata on CRaC snapshot restore #3036

ArtyomGabeev · 2023-02-26T15:48:34Z

What does this PR do?

Checklist

Initial proposal for #2982

cla-checker-service · 2023-02-26T15:48:38Z

💚 CLA has been signed

github-actions · 2023-02-26T15:48:54Z

👋 @ArtyomGabeev Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

apmmachine · 2023-02-26T15:52:13Z

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-07-03T11:39:23.264+0000
Duration: 4 min 56 sec

Steps errors

Expand to view the steps failures

`Load a resource file from a library`

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/apm-agent-java.yml

`Error signal`

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/ArtyomGabeev return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/ArtyomGabeev : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/ArtyomGabeev : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run benchmark tests : Run the benchmark tests.
run jdk compatibility tests : Run the JDK Compatibility tests.
run integration tests : Run the Agent Integration tests.
run end-to-end tests : Run the APM-ITs.
run windows tests : Build & tests on windows.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ArtyomGabeev · 2023-02-26T16:31:02Z

...gin/src/main/java/co/elastic/apm/agent/awslambda/helper/AbstractLambdaTransactionHelper.java

@@ -143,6 +143,8 @@ private void completeMetaData(Context lambdaContext) {
            String region = arnSegments[3];
            String accountId = arnSegments[4];

+            String logStreamName = lambdaContext.getLogStreamName();


unfortunately, after snapshot restore, this method returns null, so lambda instance has <uknown> node name instead of CloudWatch log stream name.

AWS team replied, that this environment variable won't be available, since it's impossible to change env variables after snapshot it taken.

We need to decide for a fallback strategy, how to generate lambda instance identifier.

I've got a reply from AWS that neither AWS_LAMBDA_LOG_STREAM_NAME, neither context.getLogStreamName gonna be populated for SnapStart enabled functions - aws/aws-lambda-java-libs#402 .

I do not know, if Kibana product have some special handling of AWS lambda APM data and if it relies on the format of configured_name from service.node field.

In initial proposal, I suggest to simulate and generate similar to log group node name, but right now I think we do not need to tie (if possible) instance name to log group name at all.

If we need just to distinguish different lambda instances, may be pair of lambda version + ephemeral id is enough, but this is a breaking change, if we are going to change it for all AWS Lambdas.

Another option I'm considering is to introduce a property, which will be a strategy for lambda instance naming.
By default, we should still try to use AWS_LAMBDA_LOG_STREAM_NAME env variable, but we may allow another one, which will use auto generated name.

botelastic · 2023-05-08T15:05:41Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

ArtyomGabeev · 2023-05-08T19:28:51Z

+1

jackshirazi · 2023-06-15T10:40:24Z

Hi @ArtyomGabeev , thank you for this contribution it's really interesting! I'll be looking at this, it may take a little while as I'm also on other things. First thing though, can you please sign the contributor agreement

elastic-apm-agent-premain/src/main/java/co/elastic/apm/agent/premain/AgentMain.java

ArtyomGabeev · 2023-07-04T08:40:40Z

I'm trying to sing contribution agreement, but do no receive any confirmation email.

jackshirazi · 2023-07-04T10:39:27Z

You seem to have 2 email addresses, one is signed up but the one associated with this PR isn't. I've tried to add the latter email address, did you get an email?

ArtyomGabeev · 2023-07-07T09:49:54Z

You seem to have 2 email addresses, one is signed up but the one associated with this PR isn't. I've tried to add the latter email address, did you get an email?

Thank you, looks like CLA is signed off.

botelastic · 2023-09-05T10:43:44Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

ArtyomGabeev · 2023-09-12T08:18:35Z

+1

botelastic · 2023-11-11T08:42:13Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

NicklasWallgren · 2023-11-11T09:09:02Z

+1

botelastic · 2024-01-10T09:53:47Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

jackshirazi · 2024-01-10T16:40:51Z

still pending :+1

v1v · 2024-02-09T08:12:49Z

run docs-build

botelastic · 2024-04-09T08:27:07Z

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

botelastic · 2024-04-23T08:27:12Z

Hi! This issue has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this issue if you think it should stay open. Thank you for your contribution!

github-actions bot added agent-java community Issues and PRs created by the community triage labels Feb 26, 2023

ArtyomGabeev marked this pull request as ready for review February 26, 2023 16:25

ArtyomGabeev commented Feb 26, 2023

View reviewed changes

eyalkoren added the 8.9-candidate label Feb 27, 2023

eyalkoren mentioned this pull request Feb 27, 2023

OpenJDK CRaC support #2982

Open

botelastic bot added the stalled label May 8, 2023

botelastic bot removed the stalled label May 8, 2023

agabeev-godaddy added 3 commits May 10, 2023 19:09

Refresh tracer metadata on CRaC snapshot restore

50395b8

Fix build

f9c54f8

update changelog

9ce97f8

ArtyomGabeev force-pushed the crac-support branch from 05e4839 to 9ce97f8 Compare May 10, 2023 16:40

agabeev-godaddy added 5 commits May 10, 2023 20:08

update changelog

b26b1d5

complete faas on snapstart restore

ffd41ca

ref

e528cc8

Merge branch 'elastic-main' into crac-support

d7d1d71

ref

34ea80b

jackshirazi reviewed Jun 15, 2023

View reviewed changes

elastic-apm-agent-premain/src/main/java/co/elastic/apm/agent/premain/AgentMain.java Show resolved Hide resolved

botelastic bot added the stalled label Sep 5, 2023

botelastic bot removed the stalled label Sep 12, 2023

botelastic bot added the stalled label Nov 11, 2023

botelastic bot removed the stalled label Nov 11, 2023

botelastic bot added the stalled label Jan 10, 2024

botelastic bot removed the stalled label Jan 10, 2024

botelastic bot added the stalled label Apr 9, 2024

botelastic bot closed this Apr 23, 2024

jackshirazi reopened this May 2, 2024

botelastic bot removed the stalled label May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refresh tracer metadata on CRaC snapshot restore #3036

Refresh tracer metadata on CRaC snapshot restore #3036

ArtyomGabeev commented Feb 26, 2023 •

edited

cla-checker-service bot commented Feb 26, 2023 •

edited

github-actions bot commented Feb 26, 2023

apmmachine commented Feb 26, 2023 •

edited

Build stats

`Load a resource file from a library`

`Error signal`

ArtyomGabeev Feb 26, 2023

ArtyomGabeev Feb 28, 2023

botelastic bot commented May 8, 2023

ArtyomGabeev commented May 8, 2023

jackshirazi commented Jun 15, 2023 •

edited

ArtyomGabeev commented Jul 4, 2023

jackshirazi commented Jul 4, 2023

ArtyomGabeev commented Jul 7, 2023

botelastic bot commented Sep 5, 2023

ArtyomGabeev commented Sep 12, 2023

botelastic bot commented Nov 11, 2023

NicklasWallgren commented Nov 11, 2023

botelastic bot commented Jan 10, 2024

jackshirazi commented Jan 10, 2024

v1v commented Feb 9, 2024

botelastic bot commented Apr 9, 2024

botelastic bot commented Apr 23, 2024

Refresh tracer metadata on CRaC snapshot restore #3036

Are you sure you want to change the base?

Refresh tracer metadata on CRaC snapshot restore #3036

Conversation

ArtyomGabeev commented Feb 26, 2023 • edited

What does this PR do?

Checklist

cla-checker-service bot commented Feb 26, 2023 • edited

github-actions bot commented Feb 26, 2023

apmmachine commented Feb 26, 2023 • edited

❕ Build Aborted

Build stats

Steps errors

Load a resource file from a library

Error signal

🤖 GitHub comments

ArtyomGabeev Feb 26, 2023

Choose a reason for hiding this comment

ArtyomGabeev Feb 28, 2023

Choose a reason for hiding this comment

botelastic bot commented May 8, 2023

ArtyomGabeev commented May 8, 2023

jackshirazi commented Jun 15, 2023 • edited

ArtyomGabeev commented Jul 4, 2023

jackshirazi commented Jul 4, 2023

ArtyomGabeev commented Jul 7, 2023

botelastic bot commented Sep 5, 2023

ArtyomGabeev commented Sep 12, 2023

botelastic bot commented Nov 11, 2023

NicklasWallgren commented Nov 11, 2023

botelastic bot commented Jan 10, 2024

jackshirazi commented Jan 10, 2024

v1v commented Feb 9, 2024

botelastic bot commented Apr 9, 2024

botelastic bot commented Apr 23, 2024

ArtyomGabeev commented Feb 26, 2023 •

edited

cla-checker-service bot commented Feb 26, 2023 •

edited

apmmachine commented Feb 26, 2023 •

edited

`Load a resource file from a library`

`Error signal`

jackshirazi commented Jun 15, 2023 •

edited