Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused API and resolve naming ambiguities #3561

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

raphw
Copy link
Contributor

@raphw raphw commented Mar 13, 2024

This PR makes a clear distinction between API and implementation, and cleans up a bit. For this:

  • The internal Tracer API is removed.
  • Implementation versions of API types are suffixed Impl.
  • The ServiceAwareTracer API is consolidated with the Tracer API.
  • Minor clean up of dependency imports.

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Mar 13, 2024
Copy link

👋 @raphw Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

@botelastic
Copy link

botelastic bot commented May 12, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the stalled label May 12, 2024
raphw added 2 commits May 16, 2024 23:16
# Conflicts:
#	apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracer.java
#	apm-agent-core/src/main/java/co/elastic/apm/agent/report/serialize/DslJsonSerializer.java
#	apm-agent-plugins/apm-profiling-plugin/src/main/java/co/elastic/apm/agent/profiler/CallTree.java
#	apm-agent-plugins/apm-profiling-plugin/src/main/java/co/elastic/apm/agent/profiler/SamplingProfiler.java
@botelastic botelastic bot removed the stalled label May 16, 2024
# Conflicts:
#	apm-agent-core/src/test/java/co/elastic/apm/agent/impl/ElasticApmTracerTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants