github-actions: refactor docker #3626
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help with using docker to fetch the artifacts with some build-args This will make the docker image be agnostic to the host In addition, it removes the complexity for using shell scripts and use antive github action support
|
The #3652 PR is also likely to introduce a few other conflicts, but the underlying issue might be implicitly fixed by only downloading and not as a fallback of the local build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use https://docs.docker.com/build/building/multi-stage/ to generate the Docker image. This will help using Docker natively to fetch the artifacts with some build-args (whether using the standalone files or fetching from Sonatype given the release version). This will make the Docker image agnostic to the host.
In addition, it removes the complexity of using shell scripts. and use native GitHub action support with tag and label detection.
Generate docker images for the snapshots using the docker tag name
test-latest.Finally, this will help us provide some provenance for the docker images, which was not done as docker build/push was in shell scripts.
Checklist